AnthonyKwon/ti_lyricstudio

Fork 0

Manually typed timestamps not registered correctly #43

New issue

Closed

opened 2026-07-30 02:47:58 +09:00 by AnthonyKwon · 4 comments

AnthonyKwon commented

2026-07-30 02:47:58 +09:00

Owner

Expected Behavior

Manually typed timestamps registered and save correctly to lyrics data.

Actual Behavior

Manually typed timestamps seems to be not registered correctly, and causes broken behaviour.

Line update makes every manual timestamp goes one line down (when only manually typed one exists)

Line update makes every manual timestamp deleted (when it's mixed)

This is not all condition tested, so there might be more.

Additional Context

I'm not sure yet. maybe botched timestamp index finding code on here? Really not sure yet, need more inspection.

                 case EditorEditTarget.Time:
                     int timestampIndex = 0;
                     for (int i = Lines.IndexOf(line) - 1; i >= 0 && Lines[i].Data.Origin == index; i++)
                         timestampIndex++;
                     // update the text of the current line
                     _file.Lines[index].Time[timestampIndex] = line.Data.Time;

## Expected Behavior Manually typed timestamps registered and save correctly to lyrics data. ## Actual Behavior Manually typed timestamps seems to be not registered correctly, and causes broken behaviour. 1. Line update makes every manual timestamp goes one line down (when only manually typed one exists) <img src="/attachments/e830ebf2-5e0d-4f71-b8d2-e84002d39b6b" width="50%"> <img src="/attachments/92b8c1f4-2064-4abb-a4b6-3d96e1845a06" width="50%"> 2. Line update makes every manual timestamp deleted (when it's mixed) <img src="/attachments/c6a7f2f8-00a2-4263-93a8-7d414be021ab" width="50%"> <img src="/attachments/ddf2e77d-3391-46c0-aa5d-bc78c665ec67" width="50%"> This is not all condition tested, so there might be more. ## Additional Context I'm not sure yet. maybe botched timestamp index finding code on here? Really not sure yet, need more inspection. https://git.thonlog.com/AnthonyKwon/ti_lyricstudio/src/commit/9571fa92841aac73cb4a48d3e12363affa47424f/ti_lyricstudio/ViewModels/PlayerUI/EditorViewModel.cs#L274-L280

Screenshot 2026-07-30 at 01.56.08.png

2.1 MiB

Screenshot 2026-07-30 at 01.55.58.png

2.1 MiB

Screenshot 2026-07-30 at 02.29.24.png

2.3 MiB

Screenshot 2026-07-30 at 02.29.32.png

2.3 MiB

AnthonyKwon added this to the 0.2.0.0 milestone

2026-07-30 02:47:58 +09:00

AnthonyKwon added the

bug

label

2026-07-30 02:47:58 +09:00

AnthonyKwon self-assigned this

2026-07-30 02:47:58 +09:00

AnthonyKwon added this to the Player UI project

2026-07-30 02:47:58 +09:00

AnthonyKwon commented

2026-07-30 02:51:56 +09:00

Author

Owner

That snippet was not a suspect since removing it didn't fix a bug. but I'll removed it on 24cb1e8524 anyway since now we have better approach.

That snippet was not a suspect since removing it didn't fix a bug. but I'll removed it on 24cb1e8524b3953338cf9603af6c9f3a270613b9 anyway since now we have better approach.

AnthonyKwon commented

2026-07-30 03:06:26 +09:00

Author

Owner

Found what's going on. For some reason, timestamp content is applied one time later. I don't know why it happens, and who causes it yet...

Found what's going on. For some reason, timestamp content is applied one time later. I don't know why it happens, and who causes it yet... ![Screenshot 2026-07-30 at 03.05.39](/attachments/64c77138-9358-47ec-be04-72c59efb50bd) ![Screenshot 2026-07-30 at 03.05.55](/attachments/e298e611-3894-4566-9686-639987022d61)

Screenshot 2026-07-30 at 03.05.39.png

524 KiB

Screenshot 2026-07-30 at 03.05.55.png

521 KiB

AnthonyKwon commented

2026-07-30 03:08:29 +09:00

Author

Owner

+ it seems to be happen on text too, just much less frequently than timestamp.

\+ it seems to be happen on text too, just much less frequently than timestamp. <img src="/attachments/15153958-0ae1-4882-af9b-fd0ce47e917c" width="50%"> <img src="/attachments/33fe03e2-9745-4cb8-bfb3-d2eca0c3bdf1" width="50%">

Screenshot 2026-07-30 at 01.53.52.png

2 MiB

Screenshot 2026-07-30 at 01.53.59.png

2 MiB

AnthonyKwon added the

Priority

High

label

2026-07-30 03:14:03 +09:00

AnthonyKwon commented

2026-07-31 11:17:36 +09:00

Author