Voice and Threads are coupled too much #39
Labels
No labels
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: AnthonyKwon/chattybot#39
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Expected Behavior
Even VC join and Thread creation state is desynchronised, Bot should work without issue.
Actual Behavior
When VC and Thread state is desynchronised, bot starts to act weird.
(I'll assume as Thread failed to create, which happens most for this issue)
/join: Bot tries to leave VC asDiscordVoiceobject exists, and callsthreadEvent.remove(). However, as thread haven't created,threadMap.get()ofDiscordThreadobject returnsundefined. So application throws anTypeError./leave: Bot tries to check existance of both VC and Threads, but will fail as thread does not exist. So bot will just show "VC not joined" message.Possible Solution
Voice and Thread codes are coupled too much overall, we should decouple it.
Closing as fixed by #43.